This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] linux-nat: Remove unnecessary xstrdup

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Pedro Alves <palves at redhat dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Wed, 17 Jan 2018 12:36:25 -0500
Subject: Re: [PATCH 1/2] linux-nat: Remove unnecessary xstrdup
Authentication-results: sourceware.org; auth=none
References: <1514732385-5506-1-git-send-email-simon.marchi@ericsson.com> <14229ad8-5663-ff4a-51b1-479f75bcd3fe@redhat.com>

On 2018-01-17 07:25, Pedro Alves wrote:

On 12/31/2017 02:59 PM, Simon Marchi wrote:

I think this xstrdup is not useful. We can pass ex.message directlyto
throw_error instead.

gdb/ChangeLog:

	* linux-nat.c (linux_nat_attach): Remove xstrdup.


LGTM.

Thanks,
Pedro Alves


Thanks, I pushed both patches.

Simon

References:
- Re: [PATCH 1/2] linux-nat: Remove unnecessary xstrdup
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]