This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4 00/11] Split up s390-linux-tdep.c
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: prudo at linux dot vnet dot ibm dot com (Philipp Rudo)
- Cc: gdb-patches at sourceware dot org, arnez at linux dot vnet dot ibm dot com (Andreas Arnez), qiyaoltc at gmail dot com (Yao Qi)
- Date: Tue, 9 Jan 2018 15:09:34 +0100 (CET)
- Subject: Re: [PATCH v4 00/11] Split up s390-linux-tdep.c
- Authentication-results: sourceware.org; auth=none
Hi Philipp,
> Philipp Rudo (11):
> s390: Remove duplicate checks for cached gdbarch at init
> s390: Allocate gdbarch & tdep at start of gdbarch init
> s390: gdbarch_tdep.have_* int -> bool
> s390: gdbarch_tdep add field tdesc
> s390: Move tdesc validation to separate function
> s390: if -> gdb_assert for tdesc_has_registers check
> s390: Hook s390 into OSABI mechanism
> s390: gdbarch_tdep add hook for syscall record
> s390: Split up s390-linux-tdep.c into two files
> s390: Move record-replay to s390-tdep
> s390: Clean up s390-linux-tdep.c
I've looked over the series again, and it looks good to me now.
So unless Andreas has further comments, I think this is OK to
commit ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com