This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5 2/2] Implement pahole-like 'ptype /o' option
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org, tom at tromey dot com, simon dot marchi at ericsson dot com, palves at redhat dot com, keiths at redhat dot com
- Date: Wed, 13 Dec 2017 12:14:16 -0500
- Subject: Re: [PATCH v5 2/2] Implement pahole-like 'ptype /o' option
- Authentication-results: sourceware.org; auth=none
- References: <20171121160709.23248-1-sergiodj@redhat.com> <20171213031724.22721-1-sergiodj@redhat.com> <20171213031724.22721-3-sergiodj@redhat.com> <83k1xqvc14.fsf@gnu.org>
On Wednesday, December 13 2017, Eli Zaretskii wrote:
>> From: Sergio Durigan Junior <sergiodj@redhat.com>
>> Cc: Tom Tromey <tom@tromey.com>, Eli Zaretskii <eliz@gnu.org>, Simon
>> Marchi <simon.marchi@ericsson.com>, Pedro Alves <palves@redhat.com>,
>> Keith Seitz <keiths@redhat.com>, Sergio Durigan Junior
>> <sergiodj@redhat.com>
>> Date: Tue, 12 Dec 2017 22:17:24 -0500
>>
>> This commit implements the pahole-like '/o' option for 'ptype', which
>> +Issuing a @kbd{ptype /o struct tuv} would print:
> ^
> Please insert "command" after the command, where I indicated.
> Otherwise the sentence reads awkward.
Done.
>> +Notice the format of the first column of comments. There, you can
>> +find two parts separated by the @code{|} character: the @emph{offset},
> ^^^^^^^^
> @samp, not @code.
Fixed.
> The documentation parts are okay with these fixed.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/