This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/3] Fix regression: expression completer and scope operator (PR gdb/22584)
On 12/13/2017 03:57 PM, Simon Marchi wrote:
> On 2017-12-13 08:26 AM, Pedro Alves wrote:
>> This patch series fixes PR gdb/22584, a regression in the expression
>> completer:
>>
>> "(gdb) p std::[TAB]" => "(gdb) p std::std::"
>>
>> GDB got confused above, there's no such thing as "std::std::".
>>
>> Patch #1 factors out some code duplicated throughout the codebase.
>>
>> The new function patched by patch #1 is used by patch #2 (the actual fix) uses.
>>
>> Patch #3 fixes something in the new completion testing support
>> routines that I noticed while writing the tests for patch #2.
>>
>> Pedro Alves (3):
>> Factor out final completion match string building
>> Fix regression: expression completer and scope operator (PR gdb/22584)
>> Tighten regexp of
>> lib/completion-support.exp:test_gdb_complete_tab_multiple
>>
>> gdb/cli/cli-decode.c | 41 +----------
>> gdb/completer.c | 115 +++++++++++++++++++++----------
>> gdb/completer.h | 24 ++++++-
>> gdb/interps.c | 20 +-----
>> gdb/symtab.c | 52 ++------------
>> gdb/testsuite/gdb.cp/cpcompletion.exp | 42 +++++++++++
>> gdb/testsuite/gdb.cp/pr9594.cc | 13 ++++
>> gdb/testsuite/lib/completion-support.exp | 7 +-
>> 8 files changed, 169 insertions(+), 145 deletions(-)
>
> That series looks good to me.
Thanks, pushed.
Pedro Alves