This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Record nested types
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 1 Dec 2017 19:13:01 +0000
- Subject: Re: [PATCH] Record nested types
- Authentication-results: sourceware.org; auth=none
- References: <750ffd14-bc4b-2440-e781-50b1d8c2ac89@redhat.com> <20171031190308.18094-1-keiths@redhat.com> <2798a979-42bb-2faf-c2e3-ee9078c69ebc@redhat.com> <e8c180d6-5340-e3b8-5876-aa5034ecb288@redhat.com> <48b9640d-05be-d593-ecf0-649c785ee1e9@redhat.com> <5f80cc27-b5fc-1700-d2a2-aa40b1ad2cb2@redhat.com>
On 12/01/2017 06:20 PM, Keith Seitz wrote:
> On 12/01/2017 04:36 AM, Pedro Alves wrote:
>>> If you'd like me to submit in full again, please let me know. Otherwise, I've appended the diff for nested-types.exp with changes necessary to get "output source file" working. I apparently broke it along the way.
>>
>> It would have been nice to have seen what the new .cc looks like too.
>>
>> But if the end result includes a comment in the .cc files mentioned that
>> this is a generated file (maybe even include a "-*- buffer-read-only: t"
>> marker at the top), then this is fine with me.
>
> How does this look?
Looks fine, thanks.
Pedro Alves