This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4] Add support for the readnever concept
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Pedro Alves <palves at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>, Joel Brobecker <brobecker at adacore dot com>, Yao Qi <qiyaoltc at gmail dot com>, Eli Zaretskii <eliz at gnu dot org>
- Date: Fri, 01 Dec 2017 12:21:26 -0500
- Subject: Re: [PATCH v4] Add support for the readnever concept
- Authentication-results: sourceware.org; auth=none
- References: <1467838463-15786-1-git-send-email-brobecker@adacore.com> <20171130002529.10592-1-sergiodj@redhat.com> <6765d36f-8603-9cd3-0476-801a5bfe0865@redhat.com> <87shcvgj55.fsf@redhat.com> <d912d6af-2500-56bc-5e40-a048c2dbd9e9@redhat.com> <87mv325pz8.fsf@tromey.com>
On Friday, December 01 2017, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> On 12/01/2017 04:35 AM, Sergio Durigan Junior wrote:
>>>> If readnever_symbol_files is set, then it'll have been propagated to
> objfile-> flags before we get here, no?
>>>
>>> Hm, I think so, yes. I mean, assuming that objfile != NULL when we call
>>> the readers, then yes;
>
> Pedro> Certainly you can assume that. A reader's job is to read
> Pedro> in the passed in objfile. The very first line of elf_symfile_read
> Pedro> would immediately crash otherwise, for example.
>
> Perhaps an ATTRIBUTE_NONNULL is in order somewhere.
I thought about a gdb_assert, actually. But yeah, I agree. I'll push
what Pedro has approved, and if he's OK with it, I'll prepare a patch
with a gdb_assert.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/