This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC v2][2/2] Target FP: Make use of MPFR if available
- From: Pedro Alves <palves at redhat dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>, John Baldwin <jhb at freebsd dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 29 Nov 2017 18:04:47 +0000
- Subject: Re: [RFC v2][2/2] Target FP: Make use of MPFR if available
- Authentication-results: sourceware.org; auth=none
- References: <20171129175536.A27B8D80320@oc3748833570.ibm.com>
On 11/29/2017 05:55 PM, Ulrich Weigand wrote:
> John Baldwin wrote:
>
>> FreeBSD's stdint.h uses _SYS_STDINT_H_ as it's include guard for <stdint.h>,
>> so this check doesn't work. Perhaps GDB's sources should just define
>> MPFR_USE_INTMAX_T explicitly after ensuring <stdint.h> is included? That
>> would seem to be the most portable approach and I think is what the
>> "Portable software should not rely on these tests" implies.
>
> I agree. GDB now requires C++11, which always has intmax_t, so it should
> be fine to simply always require this.
And even if a compiler isn't compliant for some reason, we'd
get a stdint.h replacement via gnulib that provides intmax_t.
Thanks,
Pedro Alves