This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, gdb/testsuite] Fix wrong return type in tests
- From: Pedro Alves <palves at redhat dot com>
- To: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 29 Nov 2017 11:04:52 +0000
- Subject: Re: [PATCH, gdb/testsuite] Fix wrong return type in tests
- Authentication-results: sourceware.org; auth=none
- References: <e998867a-08b5-cbf2-004b-b9ce3d73c588@foss.arm.com>
On 11/29/2017 10:48 AM, Thomas Preudhomme wrote:
> index 0990430c128413ecc21bcf65ebf58a1899f535fa..9f63fefcaeb800f7444fe74225514d3330036e5b 100644
> --- a/gdb/testsuite/gdb.cp/psymtab-parameter.cc
> +++ b/gdb/testsuite/gdb.cp/psymtab-parameter.cc
> @@ -16,7 +16,7 @@
> along with this program. If not, see <http://www.gnu.org/licenses/>. */
>
> template <typename T>
> -long
> +void
> func ()
> {
> }
> diff --git a/gdb/testsuite/gdb.cp/psymtab-parameter.exp b/gdb/testsuite/gdb.cp/psymtab-parameter.exp
> index 3d78de91f4b3752d754bd776ae3532700a308a40..5c4b6ac71927fe9030bd9ce66111761425ab433b 100644
> --- a/gdb/testsuite/gdb.cp/psymtab-parameter.exp
> +++ b/gdb/testsuite/gdb.cp/psymtab-parameter.exp
> @@ -31,6 +31,6 @@ gdb_test_no_output "set language c++"
> # XFAIL than FAIL here. For example -readnow breaks it.
> gdb_test_no_output "maintenance info symtabs"
>
> -# GDB has shown only the `long func<short>()' ELF symbol before, not the DWARF
> +# GDB has shown only the `void func<short>()' ELF symbol before, not the DWARF
> # symbol
> gdb_test "complete p 'func<short>(" "p 'func<short>\\(\\)"
I think the return type may have been significant for this test.
See comments around DMGL_RET_DROP in commit 900e11f9ec1e.
Thanks,
Pedro Alves