This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 13/13] Redefine REMOTE_OBS in terms of a list of sources


On 11/21/2017 10:10 PM, Tom Tromey wrote:
> This introduces REMOTE_SRCS and redefines REMOTE_OBS in terms of it.
> 
> ChangeLog
> 2017-11-21  Tom Tromey  <tom@tromey.com>
> 
> 	* Makefile.in (REMOTE_SRCS): New variable.
> 	(REMOTE_OBS): Redefine.
> 	(SFILES): Remove remote sources.  Use REMOTE_SRCS.
> 	(ALLDEPFILES): Remove dcache.c.

This looks fine.

I think it'd be even better to get rid of REMOTE_SRCS and fold it into
the common sources.  The remote target is always included in the build,
no matter the target, nowadays.  There's no point in having these
in DEPFILES.  (And we used to have a ton of other/different remote
targets, using other protocols, and they're now all gone).  Also several
of those objects have code that is called directly from common code.

See "git grep REMOTE_OBS":

Mon Feb 25 16:02:35 1991  Cygnus John Gilmore  (cygnus at oldman)
...
        * Makefile.dist:  Distribute REMOTE_OBS into tconfig files.
        Separate INCLUDE_CFLAGS for use with lint.  Add LINTFILES.
        Add ieee-float.o to OBS.
        * tconfig/{nindy960,vxworks68,vxworks960}:  Include the desired
        REMOTE_OBS remote-interface files in the TDEPFILES and TM_FILE.
        * tconfig/i960:  FIXME.  Half-merge, produce warning if config'd.
...

If you want to go ahead and that, then it's pre-approved.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]