This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python] Allow explicit locations in breakpoints.
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: simon dot marchi at ericsson dot com, keiths at redhat dot com, gdb-patches at sourceware dot org
- Date: Fri, 17 Nov 2017 14:02:06 +0000
- Subject: Re: [python] Allow explicit locations in breakpoints.
- Authentication-results: sourceware.org; auth=none
- References: <04ccc2c4-7827-eedc-d8db-a83a0167acb6@redhat.com> <d1899991-db61-b663-7601-86dfa38449a2@redhat.com> <58311250-9ab1-39d1-99b6-07478bc8c2ab@redhat.com> <4768c7ad-cc3d-5702-fa93-40e9760d4ee8@ericsson.com> <c6934b14-6025-5638-6922-2cc3d1ef3a9c@redhat.com> <81f2b22a-ba79-cc7c-ee85-95d2d433a90e@ericsson.com> <1765bb88-8ab0-bdcd-8551-69f8dff3bcb9@redhat.com> <31ad8fb7-0e20-13a5-45d1-c9fa67b76e27@ericsson.com> <a793a568-37a9-26f5-e3ae-37820cb7ddf7@redhat.com> <83vai9ghh5.fsf@gnu.org>
On 17/11/17 13:30, Eli Zaretskii wrote:
>> From: Phil Muldoon <pmuldoon@redhat.com>
>> Date: Fri, 17 Nov 2017 11:02:08 +0000
>>
>> I just realised this needs a doc review also.
>
> Doc review coming up.
>
>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index 9246659bfb..592fe70156 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -24,6 +24,9 @@
>> gdb.new_thread are emitted. See the manual for further
>> description of these.
>>
>> + ** Python breakpoints can now accept explicit locations. See the
>> + manual for a further description of this feature.
>
> I think "a further" should lose the "a" part. Also, how about
> mentioning the node name in the manual where this is described?
OK.
>> +@code{break} command or, in the case of a watchpoint, by the
>> +@code{watch} command. Alternatively, create a new a explicit location
> ^^^^^^^^^^^^^^^^^^^^^^^
> The second "a" should be deleted.
OK. The other comments refer to existing documentation that I have not
actually changed. I formatted the paragraph with the additional
sentence I added and re-formatted (the wrapping affected the whole
paragraph). I have no problem making the changes you suggest, they are
good, but can I please make them in another patchset so the changes
made in this one stay related?
For the purposes of clarity, the related changes in this patch are:
+@defun Breakpoint.__init__ (spec @r{[}, type @r{[}, wp_class @r{[}, internal @r{[}, temporary @r{]}, source @r{]}, function @r{]}, label @r{]}, line @r{]]]]]]]]})
and
+Alternatively, create a new a explicit location
+breakpoint (@pxref{Explicit Locations}) according to the
+specifications contained in the key words @var{source},
+@var{function}, @var{label} and @var{line}.
Cheers
Phil