This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python][patch] Python rbreak
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 16 Nov 2017 14:19:06 +0000
- Subject: Re: [python][patch] Python rbreak
- Authentication-results: sourceware.org; auth=none
- References: <f39f6365-fc45-ea7d-10dc-5e0053db5cbb@redhat.com> <e3c7c9b4-131a-f237-6392-766a65c336f9@ericsson.com> <5e1ba7e3-5f6e-2478-30a5-7670ec7a9879@redhat.com> <3193f5c7a0c98c548722bb6c143f347e@polymtl.ca> <8ee8a4c0-4580-474f-a5aa-6f76a8d22960@redhat.com> <0cac20bb-f383-f83a-e621-99f425f225d6@ericsson.com>
On 14/11/17 20:22, Simon Marchi wrote:
> On 2017-11-03 05:46 AM, Phil Muldoon wrote:
>>>>> I can't find a reference, but I think we want test names to start
>>>>> with a lower case letter and not end with a dot. I'll see if we
>>>>> can add this to the testcase cookbook wiki page.
>>>>
>>>> As I mentioned on IRC, I've not heard of it but will happily change
>>>> the names to comply.
>>
>> Sorry this took a bit longer to get back out than I would have liked.
>> Modified patch follows. I believe I have incorporated yours, Eli's and
>> Kevin's comments. ChangeLogs remain the same (other than the new NEWS
>> entry which I have added locally.)
>
> Hi Phil,
>
> Sorry for the wait, I had missed the update. The patch looks good to me,
> with just a nit below.
>
>> + if (obj_name == NULL)
>> + return NULL;
>> +
>> + /* Is the object file still valid? */
>> + if (obj_name == Py_None)
>> + continue;
>> +
>> + gdb::unique_xmalloc_ptr<char> filename =
>> + python_string_to_target_string (obj_name.get ());
>> +
>> + if (filename == NULL)
>> + return NULL;
>> +
>> + /* Make sure there is a definite place to store the value of
>> + s before it is released. */
>
> "of s" -> "of filename" ?
>
> Simon
So committed, with that additional change.
commit d8ae99a7b08e29e31446aee1e47e59943d7d9926
Thanks for the review
Cheers
Phil