This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] Fix mem region parsing regression and add test

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 14 Nov 2017 16:43:43 -0500
Subject: Re: [PATCH 2/2] Fix mem region parsing regression and add test
Authentication-results: sourceware.org; auth=none
References: <1510269503-12483-1-git-send-email-simon.marchi@ericsson.com> <1510269503-12483-2-git-send-email-simon.marchi@ericsson.com>

On 2017-11-09 18:18, Simon Marchi wrote:

In my patch

  Get rid of VEC (mem_region)
  a664f67e50eff30198097d51cec0ec4690abb2a1

I introduced a regression, where the length of the memory region is

assigned to the "hi" field. It should obviously be computed as "start+

length".  To my defense, no test had caught this :).  As a penance, I
wrote one.

I have pushed this patch (2/2), since it's a bug fix and I don't want toforget it. Patch 1/2 is still up for review, especially the part aboutupdating the file on the website.


Simon

References:
- [PATCH 1/2] Fix issues with gdb-memory-map.dtd
  - From: Simon Marchi
- [PATCH 2/2] Fix mem region parsing regression and add test
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]