This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[committed v7 1/3] BFD: Write Linux core PRSTATUS note into MIPS core file
- From: "Maciej W. Rozycki" <macro at mips dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Djordje Todorovic <djordje dot todorovic at rt-rk dot com>, <binutils at sourceware dot org>, <gdb-patches at sourceware dot org>, "nemanja dot popov at rt-rk dot com" <nemanja dot popov at rt-rk dot com>, <petar dot jovanovic at rt-rk dot com>, "Ananthakrishna Sowda (asowda)" <asowda at cisco dot com>, Nikola Prica <nikola dot prica at rt-rk dot com>
- Date: Wed, 8 Nov 2017 21:22:42 +0000
- Subject: [committed v7 1/3] BFD: Write Linux core PRSTATUS note into MIPS core file
- Authentication-results: sourceware.org; auth=none
- References: <74618d56-fa31-4cfe-329f-6a9078bac92b@rt-rk.com> <alpine.DEB.2.00.1710171449200.3886@tp.orcam.me.uk> <724f0bc9-6744-a915-d19d-77db7e9ce514@rt-rk.com> <alpine.DEB.2.00.1710252126220.3886@tp.orcam.me.uk> <64ad38a4-b8ae-912e-45d6-7048135ada2e@rt-rk.com> <alpine.DEB.2.00.1710301253210.3886@tp.orcam.me.uk> <alpine.DEB.2.00.1710301403000.3886@tp.orcam.me.uk> <8475f0b7-969d-3c27-27f2-a4944e58e954@rt-rk.com> <alpine.DEB.2.00.1711072131070.10088@tp.orcam.me.uk> <c32edd07-9381-f654-8748-fb59aa3745ca@redhat.com> <alpine.DEB.2.00.1711081950430.10088@tp.orcam.me.uk>
From: Djordje Todorovic <djordje.todorovic@rt-rk.com>
On MIPS o32, n32 and n64 platforms information such as PID was not
correctly written into core file from GDB.
This fixes that behavior.
bfd/ChangeLog:
* elf32-mips.c (elf32_mips_write_core_note): New function.
(elf_backend_write_core_note): New macro.
* elf64-mips.c (elf64_mips_write_core_note): New function.
(elf_backend_write_core_note): New macro.
* elfn32-mips.c (elf32_mips_write_core_note): New function.
(elf_backend_write_core_note): New macro.
---
bfd/elf32-mips.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
bfd/elf64-mips.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
bfd/elfn32-mips.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 132 insertions(+)
Index: binutils/bfd/elf32-mips.c
===================================================================
--- binutils.orig/bfd/elf32-mips.c 2017-11-07 21:06:16.465919208 +0000
+++ binutils/bfd/elf32-mips.c 2017-11-07 21:06:21.674163289 +0000
@@ -2373,6 +2373,45 @@ elf32_mips_grok_psinfo (bfd *abfd, Elf_I
return TRUE;
}
+
+/* Write Linux core PRSTATUS note into core file. */
+
+static char *
+elf32_mips_write_core_note (bfd *abfd, char *buf, int *bufsiz, int note_type,
+ ...)
+{
+ switch (note_type)
+ {
+ default:
+ return NULL;
+
+ case NT_PRPSINFO:
+ BFD_FAIL ();
+ return NULL;
+
+ case NT_PRSTATUS:
+ {
+ char data[256];
+ va_list ap;
+ long pid;
+ int cursig;
+ const void *greg;
+
+ va_start (ap, note_type);
+ memset (data, 0, 72);
+ pid = va_arg (ap, long);
+ bfd_put_32 (abfd, pid, data + 24);
+ cursig = va_arg (ap, int);
+ bfd_put_16 (abfd, cursig, data + 12);
+ greg = va_arg (ap, const void *);
+ memcpy (data + 72, greg, 180);
+ memset (data + 252, 0, 4);
+ va_end (ap);
+ return elfcore_write_note (abfd, buf, bufsiz,
+ "CORE", note_type, data, sizeof (data));
+ }
+ }
+}
/* Depending on the target vector we generate some version of Irix
executables or "normal" MIPS ELF ABI executables. */
@@ -2554,6 +2593,9 @@ static const struct ecoff_debug_swap mip
#define ELF_COMMONPAGESIZE 0x1000
#define elf32_bed elf32_tradbed
+#undef elf_backend_write_core_note
+#define elf_backend_write_core_note elf32_mips_write_core_note
+
/* Include the target file again for this target. */
#include "elf32-target.h"
@@ -2575,6 +2617,8 @@ static const struct ecoff_debug_swap mip
#undef elf32_bed
#define elf32_bed elf32_fbsd_tradbed
+#undef elf_backend_write_core_note
+
#include "elf32-target.h"
/* Implement elf_backend_final_write_processing for VxWorks. */
Index: binutils/bfd/elf64-mips.c
===================================================================
--- binutils.orig/bfd/elf64-mips.c 2017-11-07 21:06:16.477056388 +0000
+++ binutils/bfd/elf64-mips.c 2017-11-07 21:06:21.680225748 +0000
@@ -4248,6 +4248,45 @@ elf64_mips_grok_psinfo (bfd *abfd, Elf_I
return TRUE;
}
+
+/* Write Linux core PRSTATUS note into core file. */
+
+static char *
+elf64_mips_write_core_note (bfd *abfd, char *buf, int *bufsiz, int note_type,
+ ...)
+{
+ switch (note_type)
+ {
+ default:
+ return NULL;
+
+ case NT_PRPSINFO:
+ BFD_FAIL ();
+ return NULL;
+
+ case NT_PRSTATUS:
+ {
+ char data[480];
+ va_list ap;
+ long pid;
+ int cursig;
+ const void *greg;
+
+ va_start (ap, note_type);
+ memset (data, 0, 112);
+ pid = va_arg (ap, long);
+ bfd_put_32 (abfd, pid, data + 32);
+ cursig = va_arg (ap, int);
+ bfd_put_16 (abfd, cursig, data + 12);
+ greg = va_arg (ap, const void *);
+ memcpy (data + 112, greg, 360);
+ memset (data + 472, 0, 8);
+ va_end (ap);
+ return elfcore_write_note (abfd, buf, bufsiz,
+ "CORE", note_type, data, sizeof (data));
+ }
+ }
+}
/* ECOFF swapping routines. These are used when dealing with the
.mdebug section, which is in the ECOFF debugging format. */
@@ -4454,6 +4493,9 @@ const struct elf_size_info mips_elf64_si
#define ELF_COMMONPAGESIZE 0x1000
#define elf64_bed elf64_tradbed
+#undef elf_backend_write_core_note
+#define elf_backend_write_core_note elf64_mips_write_core_note
+
/* Include the target file again for this target. */
#include "elf64-target.h"
@@ -4476,4 +4518,6 @@ const struct elf_size_info mips_elf64_si
#undef elf64_bed
#define elf64_bed elf64_fbsd_tradbed
+#undef elf64_mips_write_core_note
+
#include "elf64-target.h"
Index: binutils/bfd/elfn32-mips.c
===================================================================
--- binutils.orig/bfd/elfn32-mips.c 2017-11-07 21:06:16.483139578 +0000
+++ binutils/bfd/elfn32-mips.c 2017-11-07 21:06:21.694354823 +0000
@@ -3632,6 +3632,45 @@ elf_n32_mips_grok_freebsd_prstatus (bfd
return _bfd_elfcore_make_pseudosection (abfd, ".reg",
size, note->descpos + offset);
}
+
+/* Write Linux core PRSTATUS note into core file. */
+
+static char *
+elf32_mips_write_core_note (bfd *abfd, char *buf, int *bufsiz, int note_type,
+ ...)
+{
+ switch (note_type)
+ {
+ default:
+ return NULL;
+
+ case NT_PRPSINFO:
+ BFD_FAIL ();
+ return NULL;
+
+ case NT_PRSTATUS:
+ {
+ char data[440];
+ va_list ap;
+ long pid;
+ int cursig;
+ const void *greg;
+
+ va_start (ap, note_type);
+ memset (data, 0, 72);
+ pid = va_arg (ap, long);
+ bfd_put_32 (abfd, pid, data + 24);
+ cursig = va_arg (ap, int);
+ bfd_put_16 (abfd, cursig, data + 12);
+ greg = va_arg (ap, const void *);
+ memcpy (data + 72, greg, 360);
+ memset (data + 432, 0, 8);
+ va_end (ap);
+ return elfcore_write_note (abfd, buf, bufsiz,
+ "CORE", note_type, data, sizeof (data));
+ }
+ }
+}
/* Depending on the target vector we generate some version of Irix
executables or "normal" MIPS ELF ABI executables. */
@@ -3824,6 +3863,9 @@ static const struct ecoff_debug_swap mip
#define ELF_COMMONPAGESIZE 0x1000
#define elf32_bed elf32_tradbed
+#undef elf_backend_write_core_note
+#define elf_backend_write_core_note elf32_mips_write_core_note
+
/* Include the target file again for this target. */
#include "elf32-target.h"
@@ -3846,4 +3888,6 @@ static const struct ecoff_debug_swap mip
#undef elf32_bed
#define elf32_bed elf32_fbsd_tradbed
+#undef elf_backend_write_core_note
+
#include "elf32-target.h"