This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 1/2] Speed up dict_hash


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> For "gdb -nx -readnow -batch gdb", this improves the time from ~9.8s
>> before to ~8.5s afterward.

Pedro> Nice!

I rebuilt today and the baseline times were higher -- now it starts at
~14.1s for an unmodified gdb, down to ~12.2 with my patch.  I'm not sure
if this is due to some other patch, or if the additional time is because
I configured differently (I enabled guile, python, and all targets in
this most recent build).  If so, 4 seconds (comparing to the ~10 seconds
last time around) seems awfully expensive for those features...

Pedro> OOC, did you check whether
Pedro>   'if (strcmp (string + 1, "KB") == 0)'
Pedro> or even:
Pedro>   if (string[1] == 'K' && string[2] == 'B' && string[3] == '\0')
Pedro> made a difference?

I tried these and they didn't make a difference.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]