Re: [RFA 4/8] Make strip_bg_char return a unique_xmalloc_ptr

[Yao Qi <qiyaoltc at gmail dot com>]

Tom Tromey <tom@tromey.com> writes:

> -  args = strip_bg_char (args, &async_exec);
> -  args_chain = make_cleanup (xfree, args);
> +  gdb::unique_xmalloc_ptr<char> stripped = strip_bg_char (args, &async_exec);
> +  args = stripped.get ();
>  
>    /* Do validation and preparation before possibly changing anything
>       in the inferior.  */
> @@ -663,9 +663,6 @@ run_command_1 (char *args, int from_tty, enum run_how run_how)
>        uiout->flush ();
>      }
>  
> -  /* Done with ARGS.  */
> -  do_cleanups (args_chain);
> -

My concern is that we may leak something if some cleanups are registered
to the cleanup chain in the callees between make_cleanup and do_cleanups
here.  However, I am not sure how to detect that.

-- 
Yao (齐尧)