This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Replace psymbol_allocation_list with std::vector

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: Tom Tromey <tom at tromey dot com>, <gdb-patches at sourceware dot org>
Date: Fri, 13 Oct 2017 22:49:51 -0600
Subject: Re: [PATCH] Replace psymbol_allocation_list with std::vector
Authentication-results: sourceware.org; auth=none
References: <1507903080-10737-1-git-send-email-simon.marchi@ericsson.com> <87k1zypxdk.fsf@tromey.com> <112a72c3-bc3e-1c2a-c108-a4ff19146902@ericsson.com>

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> It can't really hurt.  Since those lists are not expected to change after that
Simon> point, it seems useless to keep the extra unused memory in the vector.  I would
Simon> apply this fixup to my patch, WDYT?

It seems reasonable, thanks.  I suppose sometimes it could be slower.
But on the other hand it seems likely to regularly waste memory in the
current state.

Tom

Follow-Ups:
- Re: [PATCH] Replace psymbol_allocation_list with std::vector
  - From: Simon Marchi

References:
- [PATCH] Replace psymbol_allocation_list with std::vector
  - From: Simon Marchi
- Re: [PATCH] Replace psymbol_allocation_list with std::vector
  - From: Tom Tromey
- Re: [PATCH] Replace psymbol_allocation_list with std::vector
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]