This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python][patch] Python rbreak
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 13 Oct 2017 09:08:49 +0100
- Subject: Re: [python][patch] Python rbreak
- Authentication-results: sourceware.org; auth=none
- References: <f39f6365-fc45-ea7d-10dc-5e0053db5cbb@redhat.com>
On 11/10/17 12:30, Phil Muldoon wrote:
> This introduces a Python rbreak function to the Python API. Its
> functionality was designed to closely match that of the console rbreak
> but with a number of caveats.
> +
> + gdbpy_ref<> argList (Py_BuildValue("(s)", symbol_name.c_str ()));
> + gdbpy_ref<> obj (PyObject_CallObject ((PyObject *)
> + &breakpoint_object_type,
> + argList.get ()));
> +
> + /* Tolerate individual breakpoint failures. */
> + if (obj == NULL)
> + gdbpy_print_stack ();
> + else
> + {
> + PyTuple_SET_ITEM (return_tuple.get (), count, obj.get ());
> + count++;
Not sure how I missed this on the first patch run, but that obj.get ()
should be obj.release (). Apologies for noise and fixed locally.
Cheers
Phil