This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] get_integer_valueof: Don't output value in test name
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Tue, 10 Oct 2017 20:02:03 +0100
- Subject: Re: [PATCH] get_integer_valueof: Don't output value in test name
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 187A85F2981
- References: <1507661462-32717-1-git-send-email-simon.marchi@ericsson.com>
On 10/10/2017 07:51 PM, Simon Marchi wrote:
> The get_integer_valueof outputs the value it has read as part of the
> test name. This causes test names to vary from run to run, and adds
> some noise when diffing test results. e.g.:
>
> -PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (28770)
> +PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (32238)
Ideally, test result diffing tools would be ignoring
" (foo)" at the end test names, because that part is
not considered a part of the test name itself. It's
extra info. That's where we write "(timeout)", "(eof)",
etc. So for instance:
-PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid"
+FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (timeout)
... this should be considered a regression, instead of a new FAIL and
a missing PASS.
I think the buildbot diffing script is correctly ignoring that
tail end "(foo)"s.
That said, I think it's still a good idea to make the gdb.sum output
more stable across passing runs, so that plain /usr/bin/diff also
works reasonable well.
>
> This patch removes that, since it's probably not very useful.
Since we can find the number in gdb.log if we need it, this
is fine with me.
Thanks,
Pedro Alves