This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5 1/6] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd])
- From: "Doug Evans via gdb-patches" <gdb-patches at sourceware dot org>
- To: Stafford Horne <shorne at gmail dot com>
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>, GDB patches <gdb-patches at sourceware dot org>, Openrisc <openrisc at lists dot librecores dot org>, Mike Frysinger <vapier at gentoo dot org>, Peter Gavin <pgavin at gmail dot com>
- Date: Mon, 09 Oct 2017 17:00:40 +0000
- Subject: Re: [PATCH v5 1/6] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd])
- Authentication-results: sourceware.org; auth=none
- Reply-to: Doug Evans <dje at google dot com>
Stafford Horne writes:
> > > + else if (n.class == sim_fpu_class_number
> > > + && n.normal_exp <= (NR_FRAC_GUARD)) /* If not too large round. */
> >
> > This line should be aligned with the opening parenthesis (well, one char to the right).
>
> Right, that does move the comment out of the 80 char range, but just the
> ending '*/'. I hope thats ok.
A common thing to do is put the comment on the preceding line.
E.g.,
else if (n.class == sim_fpu_class_number
/* If not too large round. */
&& n.normal_exp <= (NR_FRAC_GUARD))
[appropriately tabbed of course]