This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Change search_symbols to return std::vector
- From: Simon Marchi <simark at simark dot ca>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Sun, 8 Oct 2017 21:52:42 -0400
- Subject: Re: [RFA] Change search_symbols to return std::vector
- Authentication-results: sourceware.org; auth=none
- References: <20171008225201.21755-1-tom@tromey.com>
On 2017-10-08 06:52 PM, Tom Tromey wrote:
> This changes search_symbols to return a std::vector, replacing the
> previous linked list approach. This allows the removal of some
> cleanups, as well as the use of std::sort and std::unique, saving some
> code and extra allocations in sort_search_symbols_remove_dups.
>
> Regression tested by the buildbot.
LGTM. I made a patch almost identical to this one some time ago, but then got
sidetracked trying to understand the logic of search_symbols, and then forgot
to submit it...