This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5 3/3] Extend "set cwd" to work on gdbserver
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Cc: Eli Zaretskii <eliz at gnu dot org>
- Date: Tue, 3 Oct 2017 16:15:41 +0100
- Subject: Re: [PATCH v5 3/3] Extend "set cwd" to work on gdbserver
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E120281236
- References: <20170912042325.14927-1-sergiodj@redhat.com> <20170929225852.21872-1-sergiodj@redhat.com> <20170929225852.21872-4-sergiodj@redhat.com>
This version looks good to me, with one tiny nit below.
On 09/29/2017 11:58 PM, Sergio Durigan Junior wrote:
> +/* Helper function to set the current working directory for the
> + inferior in the remote. */
"in the remote" sounds a bit odd. Missing word?
Maybe "remote target."?
> +
> +static void
> +extended_remote_set_inferior_cwd (struct remote_state *rs)
> +{
Thanks,
Pedro Alves