This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors


Pedro Alves <palves@redhat.com> writes:

>  struct gdbarch *
>  default_thread_architecture (struct target_ops *ops, ptid_t ptid)
>  {
> -  return target_gdbarch ();
> +  inferior *inf = find_inferior_ptid (ptid);
> +  gdb_assert (inf != NULL);
> +  return inf->gdbarch;
>  }

It is right, but forgot to mention that we need to update
spu_thread_architecture too,

  if (parse_spufs_run (ptid, &spufs_fd, &spufs_addr))
    return spu_gdbarch (spufs_fd);

  return target_gdbarch ();

it looks wrong to call target_gdbarch.  We may need to replace
target_gdbarch with default_thread_architecture.

-- 
Yao (齐尧)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]