This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] nto & lynx x86: call init_target_desc


On 2017-09-22 17:14, Joel Brobecker wrote:
Hi Simon,

On Fri, Sep 22, 2017 at 05:05:46PM +0200, Simon Marchi wrote:
In gdbserver, target descriptions need to be initialized by calling
init_target_desc. Because i386_create_target_description is shared with
GDB, it doesn't do that, the callers must take care of it.  These two
platforms currently don't.

I am not able to build them, so I couldn't test.

gdb/gdbserver/ChangeLog:

	* lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc.
	* nto-x86-low.c (nto_x86_arch_setup): Likewise.

For LynxOS, go right ahead. I haven't been able to build GDBserver
on LynxOS ever since we switched to C++, as there is no satisfactory
C++ compiler on this platform that I could find or build. I'm hoping
this will change sometime, but in the meantime, best effort is the
best we can do... In this case, it looks quite reasonable.

Thanks for doing that.

Thanks, I'll push the patch as-is then.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]