This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 02/11] Remove cleanups from mi_cmd_break_insert_1
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 29 Sep 2017 11:21:09 +0100
- Subject: Re: [RFA 02/11] Remove cleanups from mi_cmd_break_insert_1
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A3C1481DEF
- References: <20170912185736.20436-1-tom@tromey.com> <20170912185736.20436-3-tom@tromey.com> <294ad0fc-6500-2871-42c7-b0414dbdf563@redhat.com> <87mv5ewadz.fsf@tromey.com>
On 09/29/2017 02:39 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> IMO, it'd be even better to build the std::string directly
> Pedro> instead of building an obstack and then dupping the string.
>
> Here's the new patch.
OK, please push. Thanks for doing this.
Thanks,
Pedro Alves