This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 08/12] Remove cleanup from complaints.c
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Thu, 28 Sep 2017 23:09:09 +0100
- Subject: Re: [RFA 08/12] Remove cleanup from complaints.c
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BD81381DE8
- References: <20170928195011.27382-1-tom@tromey.com> <20170928195011.27382-9-tom@tromey.com>
On 09/28/2017 08:50 PM, Tom Tromey wrote:
> - char *msg;
> - struct cleanup *cleanups;
> - msg = xstrvprintf (fmt, args);
> - cleanups = make_cleanup (xfree, msg);
> + std::string msg (string_vprintf (fmt, args));
Please use copy-init. Otherwise OK.
Thanks,
Pedro Alves