This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 08/12] Remove cleanup from complaints.c


On 09/28/2017 08:50 PM, Tom Tromey wrote:

> -	  char *msg;
> -	  struct cleanup *cleanups;
> -	  msg = xstrvprintf (fmt, args);
> -	  cleanups = make_cleanup (xfree, msg);
> +	  std::string msg (string_vprintf (fmt, args));

Please use copy-init.  Otherwise OK.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]