This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 02/11] Remove cleanups from mi_cmd_break_insert_1

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Thu, 28 Sep 2017 13:57:30 -0600
Subject: Re: [RFA 02/11] Remove cleanups from mi_cmd_break_insert_1
Authentication-results: sourceware.org; auth=none
References: <20170912185736.20436-1-tom@tromey.com> <20170912185736.20436-3-tom@tromey.com> <294ad0fc-6500-2871-42c7-b0414dbdf563@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> IMO, it'd be even better to build the std::string directly
Pedro> instead of building an obstack and then dupping the string.

I made this change.
I'll send the new patch a bit later.

Tom

References:
- more cleanup removal, particularly in MI
  - From: Tom Tromey
- [RFA 02/11] Remove cleanups from mi_cmd_break_insert_1
  - From: Tom Tromey
- Re: [RFA 02/11] Remove cleanups from mi_cmd_break_insert_1
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]