This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH V2] dwarf2read: move producers help functions to a dwarf specific file


On 09/25/2017 03:51 PM, Walfred Tedeschi wrote:
> This patch add new files for the dwarf producer checks.

Not for the dwarf producer checks, but for the producer parsing.
Please update.

> +#include "defs.h"
> +#include "producer.h"
> +#include "utils.h"
> +
> +#if defined GDB_SELF_TEST
> +#include "selftest.h"
> +#endif

This "selftest.h" inclusion doesn't belong in this patch.
Please move it to the other patch, which actually adds the
selftests.

Otherwise OK.  Please push (this patch) once fixed.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]