This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 35/67] Constify commands maint.c, plus maintenance_print_type

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Fri, 22 Sep 2017 22:32:30 -0600
Subject: Re: [RFA 35/67] Constify commands maint.c, plus maintenance_print_type
Authentication-results: sourceware.org; auth=none
References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-36-tom@tromey.com> <caed5ae2-056c-6af2-c090-a654d966b9ae@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 09/21/2017 06:09 AM, Tom Tromey wrote:
>> 
>> @@ -591,8 +583,7 @@ maintenance_do_deprecate (char *text, int deprecate)
>> if (end_ptr != NULL)
>> {
>> len = end_ptr - start_ptr;
>> -	      start_ptr[len] = '\0';
>> -	      replacement = xstrdup (start_ptr);
>> +	      replacement = savestring (start_ptr, len);
>> }

Pedro> This looks like another "command repeat" bug fix, right?  Yay!  :-)

I hadn't noticed :)

Pedro> (Please mention it in the commit log.)

I added this to the commit message:

  In addition to the constification, this fixes a command-repeat bug.

Tom

References:
- [RFA 00/67] Simple add_cmd constification
  - From: Tom Tromey
- [RFA 35/67] Constify commands maint.c, plus maintenance_print_type
  - From: Tom Tromey
- Re: [RFA 35/67] Constify commands maint.c, plus maintenance_print_type
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]