This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] nto & lynx x86: call init_target_desc
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org, qiyaoltc at gmail dot com
- Date: Fri, 22 Sep 2017 08:14:08 -0700
- Subject: Re: [PATCH] nto & lynx x86: call init_target_desc
- Authentication-results: sourceware.org; auth=none
- References: <1506092746-17214-1-git-send-email-simon.marchi@ericsson.com>
Hi Simon,
On Fri, Sep 22, 2017 at 05:05:46PM +0200, Simon Marchi wrote:
> In gdbserver, target descriptions need to be initialized by calling
> init_target_desc. Because i386_create_target_description is shared with
> GDB, it doesn't do that, the callers must take care of it. These two
> platforms currently don't.
>
> I am not able to build them, so I couldn't test.
>
> gdb/gdbserver/ChangeLog:
>
> * lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc.
> * nto-x86-low.c (nto_x86_arch_setup): Likewise.
For LynxOS, go right ahead. I haven't been able to build GDBserver
on LynxOS ever since we switched to C++, as there is no satisfactory
C++ compiler on this platform that I could find or build. I'm hoping
this will change sometime, but in the meantime, best effort is the
best we can do... In this case, it looks quite reasonable.
Thanks for doing that.
--
Joel