This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] nto & lynx x86: call init_target_desc
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: <gdb-patches at sourceware dot org>
- Cc: <qiyaoltc at gmail dot com>, Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Fri, 22 Sep 2017 17:05:46 +0200
- Subject: [PATCH] nto & lynx x86: call init_target_desc
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon dot marchi at ericsson dot com;
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
In gdbserver, target descriptions need to be initialized by calling
init_target_desc. Because i386_create_target_description is shared with
GDB, it doesn't do that, the callers must take care of it. These two
platforms currently don't.
I am not able to build them, so I couldn't test.
gdb/gdbserver/ChangeLog:
* lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc.
* nto-x86-low.c (nto_x86_arch_setup): Likewise.
---
gdb/gdbserver/lynx-i386-low.c | 7 ++++++-
gdb/gdbserver/nto-x86-low.c | 7 ++++++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/gdb/gdbserver/lynx-i386-low.c b/gdb/gdbserver/lynx-i386-low.c
index 57181d6..a7eae1d 100644
--- a/gdb/gdbserver/lynx-i386-low.c
+++ b/gdb/gdbserver/lynx-i386-low.c
@@ -293,7 +293,12 @@ lynx_i386_store_fpregset (struct regcache *regcache, const char *buf)
static void
lynx_i386_arch_setup (void)
{
- lynx_tdesc = i386_create_target_description (X86_XSTATE_SSE_MASK, false);
+ struct target_desc *tdesc
+ = i386_create_target_description (X86_XSTATE_SSE_MASK, false);
+
+ init_target_desc (tdesc);
+
+ lynx_tdesc = tdesc;
}
/* Description of all the x86-lynx register sets. */
diff --git a/gdb/gdbserver/nto-x86-low.c b/gdb/gdbserver/nto-x86-low.c
index cfa5993..48bdc53 100644
--- a/gdb/gdbserver/nto-x86-low.c
+++ b/gdb/gdbserver/nto-x86-low.c
@@ -87,7 +87,12 @@ static void
nto_x86_arch_setup (void)
{
the_low_target.num_regs = 16;
- nto_tdesc = i386_create_target_description (X86_XSTATE_SSE_MASK, false);
+ struct target_desc *tdesc
+ = i386_create_target_description (X86_XSTATE_SSE_MASK, false);
+
+ init_target_desc (tdesc);
+
+ nto_tdesc = tdesc;
}
struct nto_target_ops the_low_target =
--
2.7.4