This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 61/67] Constify some commands in breakpoint.c
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org, Patrick Monnerat <patrick at monnerat dot net>
- Date: Thu, 21 Sep 2017 10:56:19 +0100
- Subject: Re: [RFA 61/67] Constify some commands in breakpoint.c
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7DAD42F9451
- References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-62-tom@tromey.com>
On 09/21/2017 06:10 AM, Tom Tromey wrote:
> This also makes delete_command static; but now I wonder if it is used
> in Insight and should not be touched.
[Adding Patrick]
Insight git is on sourceware nowadays:
git://sourceware.org/git/insight.git
$ git grep delete_command
...
gdbtk/generic/gdbtk-cmds.c: delete_command (NULL, 0);
I guess it'd be mildly nicer to add some "void delete_all_breakpoints();"
API instead of abusing the command callback.
Thanks,
Pedro Alves