This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] icc: allow code path for newer versions of icc.

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
Cc: Pedro Alves <palves at redhat dot com>, qiyaoltc at gmail dot com, gdb-patches at sourceware dot org
Date: Mon, 18 Sep 2017 21:13:13 +0200
Subject: Re: [PATCH] icc: allow code path for newer versions of icc.
Authentication-results: sourceware.org; auth=none
References: <1504687613-14649-1-git-send-email-walfred.tedeschi@intel.com> <59e18301-7b12-2e92-6277-0aef4164243e@redhat.com> <d7ed4db4289cc351be5bd0e1be0b16ec@polymtl.ca> <914ad9ed-940e-81e1-e7de-6c018d29aec7@intel.com>

On 2017-09-18 17:31, Tedeschi, Walfred wrote:

I am considering sending then two patches:
1. Add things in utils.c
2. move all producers to a new producers.h/c file.

Would this be ok?


(I am just speaking for myself)

I usually prefer the opposite, cleanup first then add new features(because sometimes the cleanup is promised and never comes :)), butreally I'm fine with both. The fact that you are ready to do somecleanup is appreciated.


Simon

Follow-Ups:
- Re: [PATCH] icc: allow code path for newer versions of icc.
  - From: Tedeschi, Walfred

References:
- [PATCH] icc: allow code path for newer versions of icc.
  - From: Walfred Tedeschi
- Re: [PATCH] icc: allow code path for newer versions of icc.
  - From: Pedro Alves
- Re: [PATCH] icc: allow code path for newer versions of icc.
  - From: Simon Marchi
- Re: [PATCH] icc: allow code path for newer versions of icc.
  - From: Tedeschi, Walfred

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]