Re: [PATCH] gdb - avx512: tests were failing due to missing memory aligment.

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2017-09-06 10:46, Walfred Tedeschi wrote:
> Test was running on a fault during code execution.  Analysis have shown
> that the wrong instruction had been used.  An instruction that takes
> not alligned memory is more appropriated for the task.

LGTM, you guys are the experts about that :)

> ChangeLog:
>
> 2017-06-26  Walfred Tedeschi  <walfred.tedeschi@intel.com>
>
> gdb/ChangeLog:
> 	* testsuite/gdb.arch/i386-avx512.c (move_zmm_data_to_reg): Use
> 	vmovups instead vmovaps.
> 	(move_zmm_data_to_memory): Use vmovups instead vmovaps.
>
> ---
>  gdb/testsuite/gdb.arch/i386-avx512.c | 128 
> +++++++++++++++++------------------
>  1 file changed, 64 insertions(+), 64 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.arch/i386-avx512.c
> b/gdb/testsuite/gdb.arch/i386-avx512.c
> index 52c0ead..3e955a4 100644
> --- a/gdb/testsuite/gdb.arch/i386-avx512.c
> +++ b/gdb/testsuite/gdb.arch/i386-avx512.c
> @@ -127,44 +127,44 @@ move_k_data_to_memory (void)
>  void
>  move_zmm_data_to_reg (void)
>  {
> -  asm ("vmovaps 0(%0), %%zmm0\n\t"
> -       "vmovaps 64(%0), %%zmm1\n\t"
> -       "vmovaps 128(%0), %%zmm2\n\t"
> -       "vmovaps 192(%0), %%zmm3\n\t"
> -       "vmovaps 256(%0), %%zmm4\n\t"
> -       "vmovaps 320(%0), %%zmm5\n\t"
> -       "vmovaps 384(%0), %%zmm6\n\t"
> -       "vmovaps 448(%0), %%zmm7\n\t"
> +  asm ("vmovups 0(%0), %%zmm0 \n\t"
> +       "vmovups 64(%0), %%zmm1 \n\t"
> +       "vmovups 128(%0), %%zmm2 \n\t"
> +       "vmovups 192(%0), %%zmm3 \n\t"
> +       "vmovups 256(%0), %%zmm4 \n\t"
> +       "vmovups 320(%0), %%zmm5 \n\t"
> +       "vmovups 384(%0), %%zmm6 \n\t"
> +       "vmovups 448(%0), %%zmm7 \n\t"

Any reason for the added trailing space?

Thanks,

Simon