This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] gdbserver: Remove gdb_id_to_thread_id

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Pedro Alves <palves at redhat dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Fri, 15 Sep 2017 15:43:52 +0200
Subject: Re: [PATCH 2/3] gdbserver: Remove gdb_id_to_thread_id
Authentication-results: sourceware.org; auth=none
References: <1505074275-1662-1-git-send-email-simon.marchi@ericsson.com> <1505074275-1662-3-git-send-email-simon.marchi@ericsson.com> <c66183b6-dc70-4312-61fa-909b07791ba4@redhat.com>

On 2017-09-15 12:55, Pedro Alves wrote:


-	  if (ptid_equal (gdb_id, null_ptid)
-	      || ptid_equal (gdb_id, minus_one_ptid))
+	  if (thread_id == null_ptid || thread_id == minus_one_ptid)
 	    thread_id = null_ptid;


This can be just:

	  if (thread_id == minus_one_ptid)
 	    thread_id = null_ptid;

I thought that too at first, but actually if thread_id == null_ptid,execution will take the "else" branch and things will break after.


Simon

References:
- [PATCH 0/3] Small cleanups in gdbserver
  - From: Simon Marchi
- [PATCH 2/3] gdbserver: Remove gdb_id_to_thread_id
  - From: Simon Marchi
- Re: [PATCH 2/3] gdbserver: Remove gdb_id_to_thread_id
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]