Re: [PATCH 3/4] Introduce gdb_chdir

[Sergio Durigan Junior <sergiodj at redhat dot com>]

On Thursday, September 14 2017, Pedro Alves wrote:

> On 09/14/2017 04:14 PM, Sergio Durigan Junior wrote:
>> On Wednesday, September 13 2017, Pedro Alves wrote:
>> 
>>> On 09/12/2017 05:23 AM, Sergio Durigan Junior wrote:
>
>>>> +/* Perform path expansion (i.e., tilde expansion) on DIR, and return
>>>> +   the full path.  */
>>>> +
>>>> +static std::string
>>>> +expand_path (const char *dir)
>>>
>>> Since this is particularly about tilde expansion,
>>> and a replacement for "tilde_expand", did you consider calling
>>> it gdb_tilde_expand and using it throughout?  If this were an
>>> extern function, I'd press for having "tilde" in its name,
>>> to make the call sites a bit more obvious.
>> 
>> Sure, no problem in renaming it.  Just to clarify: when you mean "use it
>> throughout", are saying that this should be used to replace readline's
>> "tilde_expand" elsewhere on GDB?
>
> Yes, and no.  Yes, by 'throughout' I meant elsewhere in GDB.
> But no, I'm not _saying_ it should.  I'm really asking if you
> considered/thought about that.

I thought about that while I was making the patch.

My very initial plan was to actually use 'wordexp', but I gave up on
that when I noticed that the function is not implemented in many targets
and gnulib doesn't provide a module for it.  So I went ahead and decided
to use glob, but left the "cd_command" untouched just because it is
"already working" (TM).

> I think what I'm really wondering is whether tilde_expand
> and this new function behave exactly the same, or whether
> glob behaves a little different in some cases.  If it behaves
> differently [and the differences are benign), then I get to
> wonder whether we should use it throughout so that different
> commands don't behave differently.
>
> E.g., does "cd *" behave the same before/after ?  Or does
> 'glob' expand '*' while tilde_expand didn't?

>From my initial tests I can see that "glob" and "tilde_expand" behave
the same, but I'll try to test more corner cases and see the results.
Apparently it'll be fine to just replace "tilde_expand".

-- 
Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible http://sergiodj.net/