This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 3/3] Make it simpler to add events to Python


>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> I think it would be clearer if you added the macro "prototype" here,
Simon> otherwise the parameter names refer to nothing.
Simon>   GDB_PY_DEFINE_EVENT_TYPE (name, py_path, py_bame, doc, base) ...

Sounds good.

Simon> The py_path and py_name are duplicated everywhere.  We could get rid
Simon> of py_path.  At the only place where it is used, we can replace it
Simon> with
Simon>   "gdb." py_name

Good point.
I've made both of these changes locally.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]