Re: [PATCH, gdb/testsuite] Fix calls in gdb.arch/thumb2-it.exp

[Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>]

On 06/09/17 16:31, Pedro Alves wrote:
> On 09/06/2017 04:26 PM, Thomas Preudhomme wrote:
> > Hi,
> >
> > Tests in gdb.arch/thumb2-it.exp call functions defined in assembly
> > without type debugging information. Since
> > 7022349d5c86bae74b49225515f42d2e221bd368
>
> I find Linux's style to refer to past commits helpful when
> reading commit logs.  I.e., also mention the commit subject, like:
>
> ... Since 7022349d5c86 ("Stop assuming no-debug-info functions
> return int"), this triggers ...
>
> This gives a clue to humans what the commit is about.

Indeed, thanks for the suggestion.

> > this triggers an error which
> > leads to many tests to FAIL. This patch cast the call to indicate the
> > return type of the functions when calling them.
>
> > Is this ok for master?
>
> OK.

Pushed.

Best regards,

Thomas