This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] Move command lines types/declarations to cli-script.h


On 09/02/2017 10:36 PM, Simon Marchi wrote:
> I think it would make more sense if the types and function declarations
> related to command lines were in cli-script.h rather than defs.h, since
> the related function definitions are in cli-script.c.
> 
> I had to add a few includes here and there.  I also had to rename the
> "lines" parameter of command_lines_deleter::operator(), because ncurses
> has a "#define lines ..." that was interfering when cli-script.h is
> included by some TUI source files that also include ncurses header files.

LGTM.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]