This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4] Implement the ability to set/unset environment variables to GDBserver when starting the inferior
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Thu, 31 Aug 2017 22:39:18 +0200
- Subject: Re: [PATCH v4] Implement the ability to set/unset environment variables to GDBserver when starting the inferior
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon dot marchi at ericsson dot com;
- References: <20170629194106.23070-1-sergiodj@redhat.com> <20170828231315.14952-1-sergiodj@redhat.com> <28c9905c-b845-a1e7-368e-fc4631e59218@ericsson.com> <87wp5j5vdm.fsf@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 2017-08-31 10:34 PM, Sergio Durigan Junior wrote:
> Anyway, thanks for the patch. Yes, from what I have checked it covers
> the existing tests. I'd probably even go further and do a
> setenv/unsetenv inside each function that needs them, so as to really
> isolate things.
>
> Do you prefer me to apply your patch on top of mine and submit a v5?
Yes, that would be best.
Simon