This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Sat, 26 Aug 2017 08:39:06 -0400
- Subject: Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate
- Authentication-results: sourceware.org; auth=none
- References: <E1dlPHW-0007LM-Eg@kwanyin.sergiodj.net>
Hello,
On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net wrote:
> My lords, ladies, gentlemen, members of the public.
>
> It is a matter of great regret and sadness to inform you that commit:
>
> remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type
> 988f6b3dc615173d6d78a76ac26c109b4582da74
>
> might have made GDB unwell. Since I am just your Butler BuildBot,
> I kindly ask that a human superior officer double-check this.
My change only touches a static function in ada-lang.c, while
the error is reported inside sparc64-tdep. Maybe an earlier commit?
--
Joel