This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/2] Change install_breakpoint to take a std::unique_ptr
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 22 Aug 2017 09:49:40 +0100
- Subject: Re: [RFA 2/2] Change install_breakpoint to take a std::unique_ptr
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 904EAC058EBE
- References: <20170820135402.1213-1-tom@tromey.com> <20170820135402.1213-3-tom@tromey.com> <b1d36e26-c505-54e8-79be-8c9953fe2fff@redhat.com> <877exwjlxm.fsf@tromey.com>
On 08/22/2017 04:55 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> [...]
> Pedro> or change add_to_breakpoint_chain to take an rvalue-ref unique_ptr
> Pedro> too, and return the raw breakpoint, and then write here:
> Pedro> breakpoint *b = add_to_breakpoint_chain (std::move (arg));
>
> Sounds good. I actually considered this but thought maybe it was a step
> too far... hah.
>
> How's this?
Perfect.
Thanks,
Pedro Alves