This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA v2 00/13] various frame filter fixes and cleanups
- From: Pedro Alves <palves at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>, Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 14 Aug 2017 15:29:53 +0100
- Subject: Re: [RFA v2 00/13] various frame filter fixes and cleanups
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A1A65C0587DB
- References: <20170814034030.20863-1-tom@tromey.com> <a350981b-0bed-f1e3-1a98-ae3266d0b579@redhat.com> <b88f34a2-f185-852a-515a-d0ed34b766e8@redhat.com>
On 08/14/2017 02:57 PM, Phil Muldoon wrote:
> I'd prefer a "hidden" attribute to the frame decorators (or a callback
> API like the rest of the functions). Returns True or False. GDB would
> honour this and print/not print the frame according to the value
> returned. This is better, to me, than a global override printing/not
> printing all elided frames.
> The bt command should still have a global
> override (IE, elide, or hidden, or show-hidden, or whatever) as
> discussed in the patch, and that would allow the user final and manual
> control of what is printed or not. I prefer frame decorators to be
> able to decide what should, or should not, be printed as the default
> as it's the presentation layer.
>
> What do you think?
Hmm, I think I'm missing the point of the difference? Can you expand on
when would a filter want to hide elided frames, and when would it want
to show them? When would it want to non-elided, but hidden frame?
What's semantically different between an elided frame and a hidden
frame? Because "hidden" and "elided" sound like synonyms to me:
<https://en.wiktionary.org/wiki/elide> - "To leave out or omit (something).".
Thanks,
Pedro Alves