This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 36/40] Add comprehensive C++ operator linespec/location/completion tests
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 9 Aug 2017 10:59:10 -0700
- Subject: Re: [PATCH 36/40] Add comprehensive C++ operator linespec/location/completion tests
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2044B119E37
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-37-git-send-email-palves@redhat.com>
On 06/02/2017 05:22 AM, Pedro Alves wrote:
>
> Grows the gdb.linespec/ tests like this:
>
> -# of expected passes 4458
> +# of expected passes 8817
Again, this is awesome.
Just one little nit.
> diff --git a/gdb/testsuite/gdb.linespec/cpls-ops.cc b/gdb/testsuite/gdb.linespec/cpls-ops.cc
> new file mode 100644
> index 0000000..c1156f1
> --- /dev/null
> +++ b/gdb/testsuite/gdb.linespec/cpls-ops.cc
> @@ -0,0 +1,253 @@
[snip]
> +
> +test_op_conversion::operator const volatile test_op_conversion_res **() const volatile
line length == 86
> +{
> + return NULL;
> +}
> +
[snip]
Otherwise, LGTM.
Keith