This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 30/40] Use search_domain::FUNCTIONS_DOMAIN when setting breakpoints
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 8 Aug 2017 14:07:26 -0700
- Subject: Re: [PATCH 30/40] Use search_domain::FUNCTIONS_DOMAIN when setting breakpoints
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 95273DB932
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-31-git-send-email-palves@redhat.com>
On 06/02/2017 05:22 AM, Pedro Alves wrote:
> however, we're currently passing down search_domain::ALL_DOMAIN when
> we know we're looking for functions, for no good reason. This patch
> fixes that.
I have a similar patch on the compile branch.
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * linespec.c (iterate_over_all_matching_symtabs): Add
> search_domain parameter. Pass it down to expand_symtabs_matching.
> (decode_objc): Request FUNCTIONS_DOMAIN symbols only.
> (lookup_prefix_sym): Adjust by passing ALL_DOMAIN as
> search_domain.
> (add_all_symbol_names_from_pspace): Add search_domain parameter.
> Pass it down.
> (find_method, find_function_symbols): Request FUNCTIONS_DOMAIN
> symbols.
> (add_matching_symbols_to_info): Add search_domain parameter. Pass
> it down.
LGTM
Keith