This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [pushed] s390-vregs.exp: Fix Tcl error after non-zero-pad patch
- From: Tom Tromey <tom at tromey dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tom at tromey dot com>
- Date: Mon, 31 Jul 2017 16:10:11 -0600
- Subject: Re: [pushed] s390-vregs.exp: Fix Tcl error after non-zero-pad patch
- Authentication-results: sourceware.org; auth=none
- References: <m34lu13i48.fsf@oc1027705133.ibm.com>
>>>>> "Andreas" == Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
Andreas> This is a regression, caused by commit 30a254669b16b8 -- "Don't always
Andreas> zero pad in print_*_chars". That patch introduced a new procedure
Andreas> "hex128" for formatting a 128-bit value as hex, but it accidentally moved
Andreas> the calculation of the 128-bit value into that new procedure as well
Andreas> instead of leaving it in the original context. This is fixed.
Thanks. I'm sorry about that. I try not to make mistakes like this by
running all my changes through the buildbot, but either it didn't report
this, or I misread the results.
Tom