This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] gdbserver lwp_info: Initialize fields, use new/delete
Simon Marchi <simon.marchi@ericsson.com> writes:
> Oh, thanks for noticing this! I think I've been misguided be the comment on
> linux_fast_tracepoint_collecting that says "true":
>
> /* Convenience wrapper. Returns true if LWP is presently collecting a
> fast tracepoint. */
>
> static int
> linux_fast_tracepoint_collecting (struct lwp_info *lwp,
> struct fast_tpoint_collect_status *status)
>
> Maybe we should make it return an enum so it's clear, because the function name
> really sounds like it would return a bool.
>
Agreed. The comments to lwp_info.collecting_fast_tracepoint should be
updated as well.
>
> Here's the a fixup to this patch that restores the original code:
The patch this fixup is good to me.
--
Yao (齐尧)