This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] gdbserver lwp_info: Initialize fields, use new/delete

From: Yao Qi <qiyaoltc at gmail dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Tue, 25 Jul 2017 10:58:45 +0100
Subject: Re: [PATCH 2/3] gdbserver lwp_info: Initialize fields, use new/delete
Authentication-results: sourceware.org; auth=none
References: <1500892797-7523-1-git-send-email-simon.marchi@ericsson.com> <1500892797-7523-3-git-send-email-simon.marchi@ericsson.com>

Simon Marchi <simon.marchi@ericsson.com> writes:

> @@ -3480,7 +3476,7 @@ linux_wait_1 (ptid_t ptid,
>        event_child->collecting_fast_tracepoint
>  	= linux_fast_tracepoint_collecting (event_child, NULL);
>  
> -      if (event_child->collecting_fast_tracepoint != 1)
> +      if (!event_child->collecting_fast_tracepoint)
>  	{
>  	  /* No longer need this breakpoint.  */
>  	  if (event_child->exit_jump_pad_bkpt != NULL)

linux_fast_tracepoint_collecting doesn't return boolean, it returns 0, 1
and 2.   See comments in tracepoint.c:fast_tracepoint_collecting.

-- 
Yao (齐尧)

Follow-Ups:
- Re: [PATCH 2/3] gdbserver lwp_info: Initialize fields, use new/delete
  - From: Simon Marchi

References:
- [PATCH 0/3] Create arch_lwp_info class hierarchy
  - From: Simon Marchi
- [PATCH 2/3] gdbserver lwp_info: Initialize fields, use new/delete
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]