This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 22/40] get_int_var_value
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Mon, 17 Jul 2017 15:11:02 -0700
- Subject: Re: [PATCH 22/40] get_int_var_value
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=keiths at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9D023356D3
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9D023356D3
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-23-git-send-email-palves@redhat.com>
On 06/02/2017 05:22 AM, Pedro Alves wrote:
> I noticed that get_int_var_value's parameters could use some
> constification. And then realized that client code would become
> simpler by changing the interface to return the success/failure
> indication as actual return value, as allows getting rid of the the
> local "boolean" variable.
It is certainly more appropriate for Joel to comment, but I did look through the patch, and it is a pretty straightforward change. I didn't notice any issues.
Keith