This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 14/40] Introduce CP_OPERATOR_STR/CP_OPERATOR_LEN and use throughout
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Fri, 14 Jul 2017 11:04:35 -0700
- Subject: Re: [PATCH 14/40] Introduce CP_OPERATOR_STR/CP_OPERATOR_LEN and use throughout
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=keiths at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B7F872560
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B7F872560
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-15-git-send-email-palves@redhat.com>
On 06/02/2017 05:22 AM, Pedro Alves wrote:
> I ran into LENGTH_OF_OPERATOR in cp-support.c and wanted to use it
> elsewhere, so I moved it to cp-support.h. Since there's already
> CP_ANONYMOUS_NAMESPACE_STR/CP_ANONYMOUS_NAMESPACE_LEN there, I
> followed the same naming pattern for the new symbols.
Looks pretty straightforward (even?) to me, but I do notice that there are still one or two places that could be updated:
c-exp.y:2281: {"operator", OPERATOR, OP_NULL, FLAG_CXX},
cp-name-parser.y:1839: if (strncmp (tokstart, "operator", 8) == 0)
Keith