This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 2/2] Remove BITS_IN_BYTES define

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 07/13/2017 01:34 PM, Tom Tromey wrote:
>> @@ -432,8 +432,8 @@ print_scalar_formatted (const gdb_byte *valaddr, struct type *type,
>> case 'd':
>> case 'u':
>> {
>> -	bool is_signed = options->format != 'u' || !TYPE_UNSIGNED (type);
>> -	print_decimal_chars (stream, valaddr, len, is_signed, byte_order);
>> +	bool is_unsigned = options->format == 'u' || TYPE_UNSIGNED (type);
>> +	print_decimal_chars (stream, valaddr, len, !is_unsigned, byte_order);
>> }
>> break;
>> case 0:

Pedro> Ah, looks like you meant to squash this hunk in the previous patch...

Oops, sorry about this.  I'll fix it up.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]